[
https://issues.apache.org/jira/browse/FLINK-19909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224241#comment-17224241
]
Kostas Kloudas edited comment on FLINK-19909 at 11/2/20, 8:03 AM:
------------------------------------------------------------------
Thanks for opening this [~fly_in_gis]! I changed this after a comment on my PR
(https://github.com/apache/flink/pull/13699) after a comment during review.
Before, in this case the error handler I was using was completing the shutdown
future of the {{Dispatcher}} exceptionally (see
https://github.com/apache/flink/pull/13699#discussion_r508494946).
BTW if the job gets cancelled, shouldn't we go throw
[here|https://github.com/kl0u/flink/blob/master/flink-clients/src/main/java/org/apache/flink/client/deployment/application/ApplicationDispatcherBootstrap.java#L280],
which is expected to put the correct exception?
was (Author: kkl0u):
Thanks for opening this [~fly_in_gis]! I changed this after a comment on my PR
(https://github.com/apache/flink/pull/13699) after a comment during review.
Before, in this case the error handler I was using was completing the shutdown
future of the {{Dispatcher}} exceptionally (see
https://github.com/apache/flink/pull/13699#discussion_r508494946).
I think this would solve the problem. Do you agree [~fly_in_gis]?
BTW if the job gets cancelled, shouldn't we go throw
[here|https://github.com/kl0u/flink/blob/master/flink-clients/src/main/java/org/apache/flink/client/deployment/application/ApplicationDispatcherBootstrap.java#L280],
which is expected to put the correct exception?
> Flink application in attach mode could not terminate when the only job is
> canceled
> ----------------------------------------------------------------------------------
>
> Key: FLINK-19909
> URL: https://issues.apache.org/jira/browse/FLINK-19909
> Project: Flink
> Issue Type: Bug
> Components: Deployment / Kubernetes, Deployment / YARN, Runtime /
> Coordination
> Affects Versions: 1.12.0, 1.11.3
> Reporter: Yang Wang
> Priority: Blocker
> Fix For: 1.12.0, 1.11.3
>
> Attachments: log.jm
>
>
> Currently, the Yarn and Kubernetes application in attach mode could not
> terminate the Flink cluster after the only job is canceled. Because we are
> throwing {{ApplicationExecutionException}} in
> {{ApplicationDispatcherBootstrap#runApplicationEntryPoint}}. However, we are
> only checking {{ApplicationFailureException}} in
> {{runApplicationAndShutdownClusterAsync}}. Then we will go to fatal error
> handler which make the jobmanager directly exits. And it has no chance to
> deregister itself to the cluster manager(Yarn/Kubernetes). That means the
> jobmanager will be relaunched by cluster manager again and again until it
> exhausts the retry attempts.
>
> cc [~kkl0u], I am not sure is this an expected change? I think it could work
> in 1.11.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
