[
https://issues.apache.org/jira/browse/FLINK-19927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224687#comment-17224687
]
Andrey Zagrebin edited comment on FLINK-19927 at 11/2/20, 2:34 PM:
-------------------------------------------------------------------
It seems we need unit tests for how EG integrates with
ExecutionStateUpdateListener and also ExecutionDeploymentListener after
FLINK-17075.
I suggest to add at least tests for integration of ExecutionStateUpdateListener
with EG in the scope of this issue, e.g. in ExecutionGraphStateUpdateTest. We
can address ExecutionDeploymentListener integration in other ticket.
wdyt? or was the plan to continue write more high level cases in
JobMasterExecutionDeploymentReconciliationTest, [~chesnay]?
was (Author: azagrebin):
It seems we need unit tests for how EG integrates with
ExecutionStateUpdateListener and also ExecutionDeploymentListener after
FLINK-17075.
I suggest to add at least tests for integration of ExecutionStateUpdateListener
with EG in the scope of this issue. We can address ExecutionDeploymentListener
integration in other ticket.
wdyt? or was the plan to continue write more high level cases in
JobMasterExecutionDeploymentReconciliationTest, [~chesnay]?
> ExecutionStateUpdateListener is only updated when legacy scheduling is enabled
> ------------------------------------------------------------------------------
>
> Key: FLINK-19927
> URL: https://issues.apache.org/jira/browse/FLINK-19927
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination
> Affects Versions: 1.12.0
> Reporter: Robert Metzger
> Assignee: Andrey Zagrebin
> Priority: Blocker
> Fix For: 1.12.0
>
>
> This is a finding from FLINK-19805.
> The {{ExecutionDeploymentTracker}} is never notified about executions
> reaching terminal state, when using the default scheduler.
> This can potentially lead to invalid execution reconciliation behavior.
> Fixing this ticket probably involves switching the statements here:
> https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java#L1688-L1692
> As part of the this tickets resolution, I suggest to also introduce a test
> case.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
