Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1734#issuecomment-190247404
Looks good, thanks!
Just one thing. If the `FlinkJoinRule` doesn't match, could we throw some
meaningful exception, e.g. "Join equality predicates should refer to fields
only"? Otherwise, the program fails with an ugly `CannotPlanException` and a
non-informative message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
