SteNicholas opened a new pull request #13925:
URL: https://github.com/apache/flink/pull/13925
## What is the purpose of the change
*`CsvRowSerializationSchema` and `CsvRowDataSerializationSchema` serialize
`Row` and `RowData` to byte array end with `\n` at default. For the row-wise
formats, it should consume and produce the bytes for a row.
`csv.line-delimiter` option is not a good option for csv format and shoud be
removed for `CsvRowSerializationSchema` and `CsvRowDataSerializationSchema` to
not append a new line.*
## Brief change log
- *`CsvSchema` in `CsvRowSerializationSchema` and
`CsvRowDataSerializationSchema` configures the line separator to empty string.*
- *`line-delimiter` option in `CsvFormatFactory`, `CsvRowFormatFactory`
and `CsvFileSystemFormatFactory` is removed.*
- *`CsvFileSystemFormatFactory` encodes `RowData` record end with line
delimiter `\n` to write.
## Verifying this change
- *Remove the line delimiter config of test cases in
`CsvRowDataSerDeSchemaTest` and `CsvRowDeSerializationSchemaTest` to verify
whether the byte array which `CsvRowSerializationSchema` and
`CsvRowDataSerializationSchema` serialize `Row` and `RowData` to includes line
delimiter `\n`.*
- *Remove the`line-delimiter` option of test cases in
`CsvFormatFactoryTest` and `CsvRowFormatFactoryTest` to verify whether the
`line-delimiter` option could be removed normally.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
