twalthr edited a comment on pull request #13770: URL: https://github.com/apache/flink/pull/13770#issuecomment-721763948
Let me answer the threads: ### Testing I was hoping we have some dummy Kinesis infrastructure already to test our connectors locally. If this is not the case, I guess we have to write a nightly end-to-end test for this purpose in a follow up issue. ### Property naming Let's discuss all metadata and properties keys real quick here before you implement them. ### Partitioning I agree. The JavaDoc is confusing in this case. I also had to read it again and was confused. I think the sentence refers to the example and should rather be `If only a subset of all partition keys (in our example a prefix part) get`. I cannot remember that we considered static partitions as only prefixes. Feel free to add another hotfix commit to fix this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
