azagrebin commented on a change in pull request #13958:
URL: https://github.com/apache/flink/pull/13958#discussion_r518789657
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adapter/DefaultExecutionTopology.java
##########
@@ -201,4 +195,32 @@ private static void connectVerticesToConsumedPartitions(
}
}
}
+
+ /**
+ * Co-location constraints are only used for iteration head and tail.
+ * A paired head and tail needs to be in the same pipelined region so
+ * that they can be restarted together.
+ */
+ private void ensureCoLocatedVerticesInSameRegion() {
+ final Map<CoLocationConstraint,
DefaultSchedulingPipelinedRegion> constraintToRegion = new IdentityHashMap<>();
Review comment:
This seems to also put `CoLocationConstraint == null` into the map.
The test also passes because of it. Is it expected? The test graph (2
disjoint JVs w/o `CoLocationConstraints`) seems to be a normal graph. Why
should the test fail?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
