becketqin commented on a change in pull request #13776:
URL: https://github.com/apache/flink/pull/13776#discussion_r519419886
##########
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManager.java
##########
@@ -112,7 +111,7 @@ public void accept(Throwable t) {
public abstract void addSplits(List<SplitT> splitsToAdd);
protected void startFetcher(SplitFetcher<E, SplitT> fetcher) {
- executors.submit(new ThrowableCatchingRunnable(errorHandler,
fetcher));
+ executors.submit(fetcher);
Review comment:
I am curious. Is there a reason that we replace the
`ThrowableCatchingRunnable` wrapper with the explicit error handler passed to
the split fetcher here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
