sjwiesman commented on a change in pull request #14002: URL: https://github.com/apache/flink/pull/14002#discussion_r520207332
########## File path: docs/try-flink/table_api.md ########## @@ -44,6 +44,13 @@ It also assumes that you are familiar with basic relational concepts such as `SE If you get stuck, check out the [community support resources](https://flink.apache.org/community.html). In particular, Apache Flink's [user mailing list](https://flink.apache.org/community.html#mailing-lists) consistently ranks as one of the most active of any Apache project and a great way to get help quickly. + +### Docker on windows Review comment: We capitalize all proper words in titles along with a new line between the header and the first ```suggestion ### Docker on Windows ``` ########## File path: docs/try-flink/table_api.md ########## @@ -44,6 +44,13 @@ It also assumes that you are familiar with basic relational concepts such as `SE If you get stuck, check out the [community support resources](https://flink.apache.org/community.html). In particular, Apache Flink's [user mailing list](https://flink.apache.org/community.html#mailing-lists) consistently ranks as one of the most active of any Apache project and a great way to get help quickly. + +### Docker on windows +if you're running docker on windows and your data generator container is failing to start then please ensure that you're using right shell. Review comment: ```suggestion If you're running docker on windows and your data generator container is failing to start then please ensure that you're using the right shell. ``` Grammar ########## File path: docs/try-flink/table_api.md ########## @@ -44,6 +44,13 @@ It also assumes that you are familiar with basic relational concepts such as `SE If you get stuck, check out the [community support resources](https://flink.apache.org/community.html). In particular, Apache Flink's [user mailing list](https://flink.apache.org/community.html#mailing-lists) consistently ranks as one of the most active of any Apache project and a great way to get help quickly. + +### Docker on windows +if you're running docker on windows and your data generator container is failing to start then please ensure that you're using right shell. +For example `docker-entrypoint.sh` for `table-walkthrough_data-generator_1` container requires bash shell. Review comment: ```suggestion For example, `docker-entrypoint.sh` for `table-walkthrough_data-generator_1` container requires bash. ``` ########## File path: docs/try-flink/table_api.md ########## @@ -44,6 +44,13 @@ It also assumes that you are familiar with basic relational concepts such as `SE If you get stuck, check out the [community support resources](https://flink.apache.org/community.html). In particular, Apache Flink's [user mailing list](https://flink.apache.org/community.html#mailing-lists) consistently ranks as one of the most active of any Apache project and a great way to get help quickly. + +### Docker on windows +if you're running docker on windows and your data generator container is failing to start then please ensure that you're using right shell. +For example `docker-entrypoint.sh` for `table-walkthrough_data-generator_1` container requires bash shell. +If you don't have it, it will throw an error `standard_init_linux.go:211: exec user process caused "no such file or directory"`. +So a workaround is to swith shell to `sh` from `bash` on the first row in `docker-entrypoint.sh` to make it work. Review comment: ```suggestion A workaround is to switch shell to `sh` from `bash` on the first row in `docker-entrypoint.sh`. ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
