[ 
https://issues.apache.org/jira/browse/FLINK-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179603#comment-15179603
 ] 

ASF GitHub Bot commented on FLINK-3570:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1758#issuecomment-192201484
  
    +1 - pretty important in my opinion
    
    please merge into 1.0 and 1.1 branches


> Replace random NIC selection heuristic by InetAddress.getLocalHost
> ------------------------------------------------------------------
>
>                 Key: FLINK-3570
>                 URL: https://issues.apache.org/jira/browse/FLINK-3570
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Runtime
>    Affects Versions: 1.0.0, 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>
> Currently, the {{ConnectionUtils.findAddressUsingStrategy}} method returns 
> the first {{NetworkInterface}} whose address is not a loop back address, not 
> a link local address and an {{Inet4Address}}. Before returning this address, 
> it is retried to connect to the {{JobManager}} using the 
> {{InetAddress.getLocalHost}} address a last time.
> The heuristic, if not choosing the {{InetAddress.getLocalHost}}, often makes 
> no sense because it returns a random {{NetworkInterface}} address. It would 
> be better to simply return the {{InetAddress.getLocalHost()}} instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to