godfreyhe commented on pull request #12998: URL: https://github.com/apache/flink/pull/12998#issuecomment-728741373
Thanks for the suggestion, > 1. Maybe we should also fix the `isDeterministic`. What do you think to have a specific `UnixTimestampSqlFunction` class? The logic stayed in `FlinkSqlOperatorTable` is quite verbose. we can't fix `isDeterministic`, because different from `getMonotonicity(SqlOperatorBinding call)`, `isDeterministic()` knows nothing about operand count. One approach is we can split `UNIX_TIMESTAMP` into two different functions, but I think it's unnecessary. If we only fix `getMonotonicity`, I trend to keep the logic in `FlinkSqlOperatorTable`. > 2. Maybe we should also fix `UUID#getMonotonicity`? good catch > 3. Is it possible to have a test to reproduce the problem? Tests have been added ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
