[ 
https://issues.apache.org/jira/browse/FLINK-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181658#comment-15181658
 ] 

Dawid Wysakowicz commented on FLINK-3574:
-----------------------------------------

I have some conceptual problem cause all of those functions take as parameters 
all NUMERIC types so that I can't use current concept with CallGenerator(needs 
specific type).
I thought about writing it as all the comparisons and arithmetic operators but 
then it would be best to extract method for generating code with method call 
(from MethodCallGenerator).
I also wonder if we want two different ways of processing - both in 
CodeGenerator::visitCall and in RexNodeTranslator::toRexNode.

I hope I described it pretty clearly, but to sum up the biggest problem I have 
is how to handle all NUMERIC types at once.

> Implement math functions for Table API
> --------------------------------------
>
>                 Key: FLINK-3574
>                 URL: https://issues.apache.org/jira/browse/FLINK-3574
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API
>            Reporter: Timo Walther
>            Assignee: Dawid Wysakowicz
>
> {code}
> MOD
> EXP
> POWER
> LN
> LOG10
> ABS
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to