Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1553#discussion_r55205009
  
    --- Diff: 
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/GroupReduceWithCombineProperties.java
 ---
    @@ -126,12 +117,66 @@ public SingleInputPlanNode instantiate(Channel in, 
SingleInputNode node) {
                        }
                        toReducer.setLocalStrategy(LocalStrategy.COMBININGSORT, 
in.getLocalStrategyKeys(),
                                                                                
in.getLocalStrategySortOrder());
    -
                        return new SingleInputPlanNode(node, "Reduce 
("+node.getOperator().getName()+")",
                                                                                
        toReducer, DriverStrategy.SORTED_GROUP_REDUCE, this.keyList);
                }
        }
     
    +   private SingleInputPlanNode injectCombinerBeforPartitioner(Channel in, 
SingleInputNode node) {
    +           // Inject a combiner before the partition node
    +           Channel channelWithPartitionSrc = new Channel(in.getSource());
    --- End diff --
    
    This channel is not really used and should not be created


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to