[
https://issues.apache.org/jira/browse/FLINK-20282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17237110#comment-17237110
]
Xintong Song commented on FLINK-20282:
--------------------------------------
Thanks for reporting this, [~zhuzh].
I think you are right. Unless there is a bug, the only possible reason of the
zero fraction is that the user has not configured the managed memory consumer
weights properly. Therefore, it makes sense to hint users with the error
message to check the configuration option.
In addition, I think we can add logs in
{{ManagedMemoryUtils#getManagedMemoryUseCaseWeightsFromConfig}} if weight of a
use case is configured to 0 or missing, which might lead to problems. We
probably should log this at the DEBUG level, given that the method is invoked
on every operator that uses managed memory.
WDYT?
> Make invalid managed memory fraction errors more advisory in MemoryManager
> --------------------------------------------------------------------------
>
> Key: FLINK-20282
> URL: https://issues.apache.org/jira/browse/FLINK-20282
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Coordination
> Affects Versions: 1.12.0
> Reporter: Zhu Zhu
> Priority: Critical
> Fix For: 1.12.0
>
>
> The invalid managed memory fraction errors[1] reported from MemoryManager are
> not advisory for users to solve the problem. This error happens when managed
> memory is required for a use case but its weight is 0. See FLINK-20116.
> I think it would be better to enrich the error message to guide users to
> properly configure "taskmanager.memory.managed.consumer-weights".
> [1] "Caused by: java.lang.IllegalArgumentException: The fraction of memory to
> allocate must within (0, 1], was: 0.0"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
