[GitHub] [flink] zhuzhurk commented on a change in pull request #14161: [FLINK-20283][python] Provide a meaningful exception message when managed memory fraction of Python worker process is invalid

[GitBox]

zhuzhurk commented on a change in pull request #14161:
URL: https://github.com/apache/flink/pull/14161#discussion_r528464485



##########
File path: 
flink-python/src/main/java/org/apache/flink/streaming/api/runners/python/beam/BeamPythonFunctionRunner.java
##########
@@ -250,7 +250,10 @@ public void open(PythonConfig config) throws Exception {
                Struct pipelineOptions = 
PipelineOptionsTranslation.toProto(portableOptions);
 
                if (memoryManager != null && config.isUsingManagedMemory()) {
-                       Preconditions.checkArgument(managedMemoryFraction > 0 
&& managedMemoryFraction <= 1.0);
+                       Preconditions.checkArgument(managedMemoryFraction > 0 
&& managedMemoryFraction <= 1.0,

Review comment:
       How about we ask users to check whether the `consumer-weights` for 
PYTHON is set to 0, which is wrong because python UDF is used?
   Because I think it is the most possible case that the check fails.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org