AHeise commented on pull request #14140: URL: https://github.com/apache/flink/pull/14140#issuecomment-731984069
> @AHeise I am getting confused. We probably have essential divergences on what `StreamTaskTestHarness.waitForInputProcessing` should do. From my understanding, it should wait until **all currently available input** has been processed not end of stream. It is waiting for an intermediate status, and could occur several times for single test harness, say three times in `TwoInputStreamTaskTest.testWatermarkMetrics`. What you try to propose here should have covered by combination of `StreamTaskTestHarness.endInput` and `StreamTaskTestHarness.waitForTaskCompletion`. That combination wait for task termination which is a terminated status, and should occur at most once for single test harness. > > @rkhachatryan gave similar suggestion in previous review cycle, I think we probably should align on what `StreamTaskTestHarness.waitForInputProcessing` should do. You are completely right. It's just very difficult to realize the original implementation without some kind of hacks and assumptions - any hotfix is prone to fail with a slight change again. I'd probably go your way but also start migrating the tests - the harness has been deprecated for a reason. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
