wuchong commented on a change in pull request #14160:
URL: https://github.com/apache/flink/pull/14160#discussion_r528543796
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
##########
@@ -537,51 +523,35 @@ class TemporalJoinITCase(state: StateBackendMode)
" ON o.currency = r.currency"
tEnv.executeSql(sql).await()
- val rawResult = getRawResults("rowtime_default_sink")
// Note: the event time semantics in delete event is when the delete event
happened,
// records "+I(2,US Dollar)" and "+I(3,RMB)" would not correlate the
deleted events
val expected = List(
- "+I(1,Euro,12,2020-08-15T00:01,null,null)",
- "+I(2,US Dollar,1,2020-08-15T00:02,null,null)",
- "+I(3,RMB,40,2020-08-15T00:03,null,null)",
- "+I(4,Euro,14,2020-08-16T00:04,118,2020-08-16T00:01)",
- "-U(2,US Dollar,1,2020-08-16T00:03,106,2020-08-16T00:02)",
- "+U(2,US Dollar,18,2020-08-16T00:03,106,2020-08-16T00:02)",
- "+I(5,RMB,40,2020-08-16T00:03,null,null)",
- "+I(6,RMB,40,2020-08-16T00:04,null,null)",
- "-D(6,RMB,40,2020-08-16T00:04,null,null)")
- assertEquals(expected.sorted, rawResult.sorted)
+ "1,Euro,12,2020-08-15T00:01,114,2020-08-15T00:00:01",
Review comment:
We drop the before messages, therefore, `1,Euro` can correlate a value
now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
