tillrohrmann commented on a change in pull request #14177:
URL: https://github.com/apache/flink/pull/14177#discussion_r529585584
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/messages/checkpoint/DeclineCheckpoint.java
##########
@@ -34,21 +35,18 @@
private static final long serialVersionUID = 2094094662279578953L;
/** The reason why the checkpoint was declined. */
+ @Nullable
private final Throwable reason;
Review comment:
I guess that we can now also adapt
`CheckpointCoordinator.getCheckpointException`.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/messages/checkpoint/DeclineCheckpoint.java
##########
@@ -34,21 +35,18 @@
private static final long serialVersionUID = 2094094662279578953L;
/** The reason why the checkpoint was declined. */
+ @Nullable
private final Throwable reason;
Review comment:
The same actually applies to the return type of `getReason()` method.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/messages/checkpoint/DeclineCheckpoint.java
##########
@@ -34,21 +35,18 @@
private static final long serialVersionUID = 2094094662279578953L;
/** The reason why the checkpoint was declined. */
+ @Nullable
private final Throwable reason;
Review comment:
Shouldn't we change the type if we know that it is always serialized?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
