[ 
https://issues.apache.org/jira/browse/FLINK-19656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239310#comment-17239310
 ] 

Etienne Chauchot commented on FLINK-19656:
------------------------------------------

[~chesnay] I guess you'll get this message on Monday. I have the impression 
that everything is already in place for this ticket. Backends that need to 
filter certain characters from the component names already define a filter as 
in [here for 
dropwizard|[https://github.com/apache/flink/blob/22679aacd04612fb01f96bbbe58012cc7b2cda58/flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java#L185]
 and pass it to 
|https://github.com/apache/flink/blob/22679aacd04612fb01f96bbbe58012cc7b2cda58/flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java#L185].]

ProxyMetricGroup#[getMetricIdentifier|https://github.com/apache/flink/blob/22679aacd04612fb01f96bbbe58012cc7b2cda58/flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java#L185].]

> Automatically replace delimiter in metric name components
> ---------------------------------------------------------
>
>                 Key: FLINK-19656
>                 URL: https://issues.apache.org/jira/browse/FLINK-19656
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Metrics
>            Reporter: Chesnay Schepler
>            Priority: Major
>              Labels: starter
>             Fix For: 1.12.0
>
>
> The metric name consists of various components (like job ID, task ID), that 
> are then joined by a delimiter(commonly {{.}}).
> The delimiter isn't just for convention, but also carries semantics for many 
> metric backends, as they organize metrics based on the delimiter.
> This can behave in unfortunate ways if the delimiter is contained with a 
> given component, as it will now be split up by the backend.
> We should automatically filter such occurrences to prevent this from 
> happening.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to