[ 
https://issues.apache.org/jira/browse/FLINK-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189036#comment-15189036
 ] 

ASF GitHub Bot commented on FLINK-2997:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1776#discussion_r55660109
  
    --- Diff: 
flink-optimizer/src/main/java/org/apache/flink/optimizer/dataproperties/GlobalProperties.java
 ---
    @@ -92,6 +95,10 @@ public void setRangePartitioned(Ordering ordering) {
                this.partitioningFields = ordering.getInvolvedIndexes();
        }
        
    +   public void setDataDistribution(DataDistribution distribution) {
    --- End diff --
    
    Can you remove the `setDataDistribution` method and add a parameter to 
`setRangePartitioned()` instead. Also add JavaDocs to `setRangePartitioned` to 
explain that the distribution is optional and might be null.


> Support range partition with user customized data distribution.
> ---------------------------------------------------------------
>
>                 Key: FLINK-2997
>                 URL: https://issues.apache.org/jira/browse/FLINK-2997
>             Project: Flink
>          Issue Type: New Feature
>            Reporter: Chengxiang Li
>
> This is a followup work of FLINK-7, sometime user have better knowledge of 
> the source data, and they can build customized data distribution to do range 
> partition more efficiently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to