dianfu commented on a change in pull request #14204:
URL: https://github.com/apache/flink/pull/14204#discussion_r531418654
##########
File path: tools/azure-pipelines/build-apache-repo.yml
##########
@@ -68,6 +68,35 @@ stages:
run_end_to_end: false
container: flink-build-container
jdk: jdk8
+ - job: docs_404_check # run on a MSFT provided machine
+ pool:
+ vmImage: 'ubuntu-16.04'
+ steps:
+ # Skip docs check if this is a pull request doesn't contain
documentation change
+ - bash: |
+ source ./tools/azure-pipelines/build_properties.sh
+ contains_docs_pullrequest
+ if [[ "$?" == 0 ]] ; then
+ echo "##[debug]This is a pull request doesn't contain
documentation. Skipping docs check."
+ echo "##vso[task.setvariable variable=skip;]1"
+ else
+ echo "##[debug]This is a regular CI build. Continuing ..."
+ echo "##vso[task.setvariable variable=skip;]0"
+ fi
+ displayName: Check if PR contains docs change
+ - task: UseRubyVersion@0
+ condition: not(eq(variables['SKIP'], '1'))
+ inputs:
+ versionSpec: '= 2.4'
+ addToPath: true
+ - script: ./tools/ci/docs.sh
+ condition: not(eq(variables['SKIP'], '1'))
+ # upload spider.log for debugging
+ - task: PublishPipelineArtifact@1
+ inputs:
+ targetPath: $(FLINK_ARTIFACT_DIR)
+ artifact: spider.log
+ condition: not(eq(variables['SKIP'], '1'))
Review comment:
```suggestion
condition: not(eq(variables['SKIP'], '1'))
```
##########
File path: azure-pipelines.yml
##########
@@ -75,6 +75,21 @@ stages:
run_end_to_end: false
container: flink-build-container
jdk: jdk8
+ - job: docs_404_check # run on a MSFT provided machine
+ pool:
+ vmImage: 'ubuntu-16.04'
+ steps:
+ - task: UseRubyVersion@0
+ inputs:
+ versionSpec: '= 2.4'
+ addToPath: true
+ - script: ./tools/ci/docs.sh
+ # upload spider.log for debugging
+ - task: PublishPipelineArtifact@1
+ inputs:
+ targetPath: $(FLINK_ARTIFACT_DIR)
+ artifact: spider.log
+ condition: not(eq(variables['SKIP'], '1'))
Review comment:
it seems that this line is unnecessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
