twalthr commented on a change in pull request #14247:
URL: https://github.com/apache/flink/pull/14247#discussion_r531491606
##########
File path:
flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/typeutils/AvroSchemaConverterTest.java
##########
@@ -54,6 +64,44 @@ public void testAvroSchemaConversion() {
validateUserSchema(AvroSchemaConverter.convertToTypeInfo(schema));
}
+ @Test
+ public void testAddingOptionalField() throws IOException {
+ Schema oldSchema = SchemaBuilder.record("record")
+ .fields()
+ .requiredLong("category_id")
+ .optionalString("name")
+ .endRecord();
+
+ Schema newSchema = AvroSchemaConverter.convertToSchema(
+ TableSchema.builder()
Review comment:
Use `DataType` directly. We should not advertise TableSchema anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
