becketqin opened a new pull request #14291:
URL: https://github.com/apache/flink/pull/14291
## What is the purpose of the change
The patch fixes a bug that the `KafkaPartitionSplitFetcher` does not finish
the pending offsets commit when the contained `KafkaConsumer` exits. This is
actually a bug in KafkaConsumer but we need to handle it for now.
The previous test tries to play a trick so that the unit test passes. We
should have handled this correctly in the `KafkaPartitionSplitFetcher` instead.
The patch also fixes the reported instability of the
`KafkaSourceReaderTest.testCommitOffsetsWithoutAliveFetchers()`.
## Brief change log
The patch tracks all the pending async commit and commit them when the
`KafkaPartitionSplitFetcher` exits.
## Verifying this change
The following unit tests have been added to verify the change.
`KafkaPartitionSplitReaderTest.testFinishPendingOffsetsCommitOnClose()`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (**no**)
- The serializers: (**no**)
- The runtime per-record code paths (performance sensitive): (**no**)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**no**)
- The S3 file system connector: (**no**)
## Documentation
- Does this pull request introduce a new feature? (**no**)
- If yes, how is the feature documented? (**not applicable**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
