[ 
https://issues.apache.org/jira/browse/FLINK-20464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dawid Wysakowicz updated FLINK-20464:
-------------------------------------
    Description: 
Some examples were moved to the 
{{org.apache.flink.table.examples.scala.basics}} package but the pom.xml was 
not updated. This means the example jars are not built correctly and do not 
contain the classes.

Examples that I noticed:
* org.apache.flink.table.examples.scala.basics.StreamTableExample
* org.apache.flink.table.examples.scala.basics.TPCHQuery3Table

We should update the {{includes}} sections e.g.:

{code}
<execution>
        <id>StreamTableExample</id>
        <phase>package</phase>
        <goals>
                <goal>jar</goal>
        </goals>
        <configuration>
                <classifier>StreamTableExample</classifier>

<!--- The sections below should be updated -->

                <archive>
                        <manifestEntries>
                                
<program-class>org.apache.flink.table.examples.scala.StreamTableExample</program-class>
                        </manifestEntries>
                </archive>
                <includes>
                        
<include>org/apache/flink/table/examples/scala/StreamTableExample*</include>
                </includes>
        </configuration>
</execution>
{code}

  was:
Some examples were moved to the 
{{org.apache.flink.table.examples.scala.basics}} package but the pom.xml was 
not updated. This means the example jars are not built correctly and do not 
contain the classes.

Examples that I noticed:
* org.apache.flink.table.examples.scala.basics.StreamTableExample
* org.apache.flink.table.examples.scala.basics.TPCHQuery3Table

We should update the {{includes}} sections e.g.:

{code}
                                        <execution>
                                                <id>StreamTableExample</id>
                                                <phase>package</phase>
                                                <goals>
                                                        <goal>jar</goal>
                                                </goals>

                                                <configuration>
                                                        
<classifier>StreamTableExample</classifier>

                                                        <archive>
                                                                
<manifestEntries>
                                                                        
<program-class>org.apache.flink.table.examples.scala.StreamTableExample</program-class>
                                                                
</manifestEntries>
                                                        </archive>

*                                                       <includes>
                                                                
<include>org/apache/flink/table/examples/scala/StreamTableExample*</include>
                                                        </includes>*
                                                </configuration>
                                        </execution>
{code}


> Some Table examples are not built correctly
> -------------------------------------------
>
>                 Key: FLINK-20464
>                 URL: https://issues.apache.org/jira/browse/FLINK-20464
>             Project: Flink
>          Issue Type: Bug
>          Components: Examples
>    Affects Versions: 1.12.0
>            Reporter: Dawid Wysakowicz
>            Priority: Critical
>             Fix For: 1.12.0
>
>
> Some examples were moved to the 
> {{org.apache.flink.table.examples.scala.basics}} package but the pom.xml was 
> not updated. This means the example jars are not built correctly and do not 
> contain the classes.
> Examples that I noticed:
> * org.apache.flink.table.examples.scala.basics.StreamTableExample
> * org.apache.flink.table.examples.scala.basics.TPCHQuery3Table
> We should update the {{includes}} sections e.g.:
> {code}
> <execution>
>       <id>StreamTableExample</id>
>       <phase>package</phase>
>       <goals>
>               <goal>jar</goal>
>       </goals>
>       <configuration>
>               <classifier>StreamTableExample</classifier>
> <!--- The sections below should be updated -->
>               <archive>
>                       <manifestEntries>
>                               
> <program-class>org.apache.flink.table.examples.scala.StreamTableExample</program-class>
>                       </manifestEntries>
>               </archive>
>               <includes>
>                       
> <include>org/apache/flink/table/examples/scala/StreamTableExample*</include>
>               </includes>
>       </configuration>
> </execution>
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to