tillrohrmann commented on a change in pull request #14300:
URL: https://github.com/apache/flink/pull/14300#discussion_r536116043
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -551,18 +559,27 @@ protected boolean useLocalCommunication() {
}
@GuardedBy("lock")
- private Collection<? extends CompletableFuture<Void>>
terminateTaskExecutors() {
+ private Collection<? extends CompletableFuture<Void>>
terminateTaskManagers() {
final Collection<CompletableFuture<Void>> terminationFutures =
new ArrayList<>(taskManagers.size());
for (int i = 0; i < taskManagers.size(); i++) {
- terminationFutures.add(terminateTaskExecutor(i));
+ terminationFutures.add(terminateTaskManager(i));
}
return terminationFutures;
}
- @VisibleForTesting
- @Nonnull
- protected CompletableFuture<Void> terminateTaskExecutor(int index) {
+ /**
+ * Terminates a TaskManager with a given index.
Review comment:
```suggestion
* Terminates a TaskManager with the given index.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
