V1ncentzzZ commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r539042698
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcExecutionOptions.java
##########
@@ -66,12 +76,13 @@ public boolean equals(Object o) {
JdbcExecutionOptions that = (JdbcExecutionOptions) o;
return batchIntervalMs == that.batchIntervalMs &&
batchSize == that.batchSize &&
- maxRetries == that.maxRetries;
+ maxRetries == that.maxRetries &&
+ parallelism == that.parallelism;
Review comment:
My suggestion is that use `equals()` instead of `==` beacause the `==`
will return false when parallelism's value more than 128.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
