GitHub user vasia opened a pull request:

    https://github.com/apache/flink/pull/1789

    [FLINK-3489] TableAPI refactoring and cleanup

    I applied the proposed changes, except from
    - remove `ExpressionException `: it is used in many places
    - remove `typeInfo()` of `Expression`: also used in several places
    - add the `ExecutionEnvironment` to the `TableEnvironment`: we probably 
also need to add the `StreamExecutionEnvironment` to the `TableEnvironment` and 
figure out a way to know if we have a batch or stream Table, so it might be a 
good idea to perform this change as part of a different issue.
    
    Another thing could do is move the DataSet rules to the 
`org.apache.flink.api.table.plan.rules` package and remove the 
`org.apache.flink.api.table.plan.rules.dataset` package. Let me know what you 
think about this. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vasia/flink refactorTable

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1789.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1789
    
----
commit 0c3679e9403c002d0761f1511dec2de597b94266
Author: vasia <[email protected]>
Date:   2016-03-14T13:16:29Z

    [FLINK-3489] TableAPI refactoring and cleanup

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to