godfreyhe commented on a change in pull request #14315:
URL: https://github.com/apache/flink/pull/14315#discussion_r539817633
##########
File path:
flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/ValuesTest.xml
##########
@@ -34,9 +34,9 @@ LogicalProject(a=[$0], b=[$1]), rowType=[RecordType(INTEGER
a, DECIMAL(20, 1) b)
<![CDATA[
Union(all=[true], union=[EXPR$0, EXPR$1]), rowType=[RecordType(INTEGER EXPR$0,
DECIMAL(20, 1) EXPR$1)]
:- Calc(select=[1 AS EXPR$0, 2.0:DECIMAL(20, 1) AS EXPR$1]),
rowType=[RecordType(INTEGER EXPR$0, DECIMAL(20, 1) EXPR$1)]
-: +- Values(tuples=[[{ 0 }]], values=[ZERO], reuse_id=[1]),
rowType=[RecordType(INTEGER ZERO)]
+: +- Values(tuples=[[{ 0 }]], values=[ZERO]), rowType=[RecordType(INTEGER
ZERO)]
+- Calc(select=[3 AS EXPR$0, 4.0:DECIMAL(20, 1) AS EXPR$1]),
rowType=[RecordType(INTEGER EXPR$0, DECIMAL(20, 1) EXPR$1)]
- +- Reused(reference_id=[1]), rowType=[RecordType(INTEGER ZERO)]
+ +- Values(tuples=[[{ 0 }]], values=[ZERO]), rowType=[RecordType(INTEGER
ZERO)]
Review comment:
because the case tests the rel plan with row type, only exec plan will
reuse the sub-plan, not rel plan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
