[
https://issues.apache.org/jira/browse/FLINK-20546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246996#comment-17246996
]
zoucao commented on FLINK-20546:
--------------------------------
hi [~jark]，thanks for your reply, Firstly. Of course I am willing to take it.
> Misuse of the method in KafkaDynamicTableFactoryTest
> ----------------------------------------------------
>
> Key: FLINK-20546
> URL: https://issues.apache.org/jira/browse/FLINK-20546
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / Kafka
> Affects Versions: 1.12.0
> Reporter: zoucao
> Priority: Major
>
> hi all, I am reading something about DynamicTable Source/Sink Factory
> recently, and one thing let me confused. In `KafkaDynamicTableFactoryTest`,
> `getBasicSourceOptions()` and `getBasicSinkOptions()` are created for source
> table and sink table, respectively. However, in the situation of validating
> sink table, `getBasicSourceOptions()` is called, for example in method
> `testSinkWithTopicListOrTopicPattern`、`testInvalidSinkSemantic` etc.
> Although no exception is thrown, it also should be fixed. WDYT?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
