Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-196314763
@stefanobaghino, really good work :-) I think we're close to get this
merged. I had some minor comments.
Concerning the testing, I agree with @StephanEwen that it's not really
necessary to execute a complete program for each new extension method. Instead,
I think it is sufficient to check that the right operator/stream transformation
has been instantiated. The operators and stream transformations should be
already well tested. For the `DataSet` methods you could do something like
```
val identityMapDs = ds.mapWith(identity)
assertTrue(identityMapDs.javaSet.isInstanceOf[MapOperator[String, String]])
```
And for the `DataStream` methods
```
val identity = stream.mapWith{case x => x}
assertTrue(identity.javaStream.getTransformation.asInstanceOf[OneInputTransformation[Int,
Int]]
.getOperator.isInstanceOf[StreamMap[Int, Int]])
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
