[ 
https://issues.apache.org/jira/browse/FLINK-20552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247034#comment-17247034
 ] 

Jark Wu commented on FLINK-20552:
---------------------------------

+1 to [~Leonard Xu]'s proposal.

We should also add a proper testing for this.  An easier way to test this is 
using {{OneInputStreamOperatorTestHarness}}. 
You can have a look at the 
{{GroupAggregateHarnessTest#testAggregateWithRetraction}} about how to create 
an operator harness by using SQL. And have a look at 
{{RowTimeDeduplicateFunctionTest#testRowTimeDeduplicateKeepLastRow(boolean, 
boolean, java.util.List<java.lang.Object>)}} about how to snapshot and restore. 

> JdbcDynamicTableSink doesn't sink buffered data on checkpoint
> -------------------------------------------------------------
>
>                 Key: FLINK-20552
>                 URL: https://issues.apache.org/jira/browse/FLINK-20552
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / JDBC, Table SQL / Ecosystem
>            Reporter: mei jie
>            Priority: Major
>              Labels: starter
>
> JdbcBatchingOutputFormat  is wrapped to OutputFormatSinkFunction``` when 
> createSinkTransformation at CommonPhysicalSink class. but 
> OutputFormatSinkFunction don't implement CheckpointedFunction interface, so 
> the flush method of JdbcBatchingOutputFormat can't be called  when checkpoint



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to