dawidwys commented on a change in pull request #14312:
URL: https://github.com/apache/flink/pull/14312#discussion_r539998701
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/sort/MultiInputSortingDataInput.java
##########
@@ -315,23 +342,40 @@ private InputStatus addNextToQueue(HeadElement reuse,
DataOutput<IN> output) thr
* element of all sorting inputs. Should be used by the {@link
StreamInputProcessor} to
* choose the next input to consume from.
*/
- private static class InputSelector implements InputSelectable {
+ private static class InputSelector implements InputSelectable,
BoundedMultiInput {
private final CommonContext commonContext;
- private final int numberOfInputs;
+ private final int numInputs;
+ private final ConcurrentLinkedQueue<Integer>
passThroughInputsIndices;
Review comment:
Do we need the `Concurrent` queue here? If I am not mistaken all of it
happens from within the main mailbox thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
