wuchong commented on a change in pull request #13932:
URL: https://github.com/apache/flink/pull/13932#discussion_r540750496
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/factories/PrintTableSinkFactory.java
##########
@@ -95,19 +96,22 @@ public DynamicTableSink createDynamicTableSink(Context
context) {
return new PrintSink(
context.getCatalogTable().getSchema().toPhysicalRowDataType(),
options.get(PRINT_IDENTIFIER),
- options.get(STANDARD_ERROR));
+ options.get(STANDARD_ERROR),
+
options.getOptional(FactoryUtil.SINK_PARALLELISM).orElse(null));
}
private static class PrintSink implements DynamicTableSink {
private final DataType type;
private final String printIdentifier;
private final boolean stdErr;
+ private final Integer parallelism;
Review comment:
```suggestion
private final @Nullable Integer parallelism;
```
Would be better to add `@Nullable` annotation.
See the Flink Code Style Guideline:
https://flink.apache.org/contributing/code-style-and-quality-java.html#java-optional
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
