AHeise commented on a change in pull request #14348:
URL: https://github.com/apache/flink/pull/14348#discussion_r543124238



##########
File path: 
flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointITCase.java
##########
@@ -321,7 +321,7 @@ public void invoke(Long value, Context context) throws 
Exception {
                        if (backpressure) {
                                // induce backpressure until enough checkpoints 
have been written
                                if (random.nextInt(100) == 42) {
-                                       Thread.sleep(0, 100_000);
+                                       Thread.sleep(100);

Review comment:
       Test duration was lower altogether because of the source throttling. In 
the worst case, with this change, a checkpoint needs 100+100 ms compared to the 
ideal time of 100 ms. But since the test is much more resource friendly now, it 
was effectively lower on my 8-core machine.
   
   The issue with your proposition is now that there may be runs without any 
backpressure, which may or may not be beneficial.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to