Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1790#discussion_r56156445
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
 ---
    @@ -781,6 +787,32 @@ class TaskManager(
         }
       }
     
    +  private def handleRequestTaskManagerLog
    +  (sender: ActorRef, requestType: LogTypeRequest, jobManager: ActorRef):
    +  Unit = {
    +    if (blobService.isDefined && jobManager.path.address.host.isDefined) {
    +      //create new Thread to upload log, to not block the TM for too long
    +      new Thread() {
    +        override def run(): Unit = {
    +          val jmHost = jobManager.path.address.host.get
    +          val port = blobService.get.getPort
    +          val logFilePath = System.getProperty("log.file");
    --- End diff --
    
    I don't think we can rely on the system property to be set correctly.
    I think the log directory is in some configuration


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to