[ 
https://issues.apache.org/jira/browse/FLINK-20687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252516#comment-17252516
 ] 

Kostas Kloudas commented on FLINK-20687:
----------------------------------------

Hi [~jiang7chengzitc], you are right about the behaviour you describe. Although 
this is the expected behaviour. The intention is that we display only the 
{{target}} options that you can actually use. In addition, in terms of code, to 
include even the non-available ones, like the {{yarn-application}} when hadoop 
is not in the classpath, we would have to hardcode them in the error message, 
something that is not so future-proof. That is because if in the future we 
choose to add another framework, then we should again remember to hardcode the 
new executor in the help message.

> Missing 'yarn-application' target in CLI help message
> -----------------------------------------------------
>
>                 Key: FLINK-20687
>                 URL: https://issues.apache.org/jira/browse/FLINK-20687
>             Project: Flink
>          Issue Type: Improvement
>          Components: Command Line Client
>    Affects Versions: 1.12.0
>            Reporter: Ruguo Yu
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.13.0, 1.12.1
>
>         Attachments: image-2020-12-20-21-48-18-391.png, 
> image-2020-12-20-22-02-01-312.png
>
>
> Missing 'yarn-application' target in CLI help message when i enter command 
> 'flink run-application -h', as follows:
> !image-2020-12-20-21-48-18-391.png|width=516,height=372!
> The target name is obtained through SPI, and I checked the SPI 
> META-INF/servicesis is correct.
>  
> Next i put flink-shaded-hadoop-*-.jar to flink lib derectory or set 
> HADOOP_CLASSPATH, it can show 'yarn-application', as follows:
> !image-2020-12-20-22-02-01-312.png|width=808,height=507!
>  However, I think it is reasonable to show 'yarn-application' without any 
> action. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to