godfreyhe commented on a change in pull request #14400: URL: https://github.com/apache/flink/pull/14400#discussion_r546597347
########## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeBase.java ########## @@ -20,6 +20,7 @@ import org.apache.flink.api.dag.Transformation; import org.apache.flink.table.delegation.Planner; +import org.apache.flink.table.planner.plan.nodes.exec.common.CommonExecExchange; Review comment: In ExecNode, We have removed type parameter `P`, the new method is `Transformation<T> translateToPlan(Planner planner)`. If we support mixed mode in the future, the BatchPlanner and StreamPlanner also need to refactor. We can refactor this after we have a clearer thought. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org