[
https://issues.apache.org/jira/browse/FLINK-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-20683.
------------------------------------
Fix Version/s: (was: 1.12.1)
(was: 1.13.0)
Resolution: Won't Fix
I don't think there's a lot we can do here. The test likely failed because the
future was already hitting the timeout before the slot was even marked as
active.
We "can't" (read: don't want) to significantly increase the timeout to prevent
this from happening because we have to wait at least the same amount of time to
assert the timeout wasn't triggered. I'll close this as 'Won't fix' for the
time being.
> TaskSlotTableImplTest.testTryMarkSlotActiveDeactivatesSlotTimeout test failed
> with "The slot timeout should have been deactivated."
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-20683
> URL: https://issues.apache.org/jira/browse/FLINK-20683
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination
> Affects Versions: 1.12.0
> Reporter: Huang Xingbo
> Priority: Critical
> Labels: test-stability
>
> [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=11071&view=logs&j=f0ac5c25-1168-55a5-07ff-0e88223afed9&t=0dbaca5d-7c38-52e6-f4fe-2fb69ccb3ada]
> {code:java}
> 2020-12-19T22:56:49.8133545Z [ERROR]
> testTryMarkSlotActiveDeactivatesSlotTimeout(org.apache.flink.runtime.taskexecutor.slot.TaskSlotTableImplTest)
> Time elapsed: 0.082 s <<< FAILURE!
> 2020-12-19T22:56:49.8135672Z java.lang.AssertionError: The slot timeout
> should have been deactivated.
> 2020-12-19T22:56:49.8136417Z at org.junit.Assert.fail(Assert.java:88)
> 2020-12-19T22:56:49.8137153Z at
> org.apache.flink.runtime.taskexecutor.slot.TaskSlotTableImplTest.runDeactivateSlotTimeoutTest(TaskSlotTableImplTest.java:344)
> 2020-12-19T22:56:49.8138303Z at
> org.apache.flink.runtime.taskexecutor.slot.TaskSlotTableImplTest.testTryMarkSlotActiveDeactivatesSlotTimeout(TaskSlotTableImplTest.java:326)
> 2020-12-19T22:56:49.8139195Z at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 2020-12-19T22:56:49.8139805Z at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 2020-12-19T22:56:49.8167569Z at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 2020-12-19T22:56:49.8168468Z at
> java.base/java.lang.reflect.Method.invoke(Method.java:566)
> 2020-12-19T22:56:49.8169248Z at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> 2020-12-19T22:56:49.8169942Z at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> 2020-12-19T22:56:49.8170657Z at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> 2020-12-19T22:56:49.8171359Z at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> 2020-12-19T22:56:49.8171983Z at
> org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> 2020-12-19T22:56:49.8172576Z at
> org.junit.rules.RunRules.evaluate(RunRules.java:20)
> 2020-12-19T22:56:49.8173209Z at
> org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> 2020-12-19T22:56:49.8173834Z at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> 2020-12-19T22:56:49.8174556Z at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> 2020-12-19T22:56:49.8174994Z at
> org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> 2020-12-19T22:56:49.8175376Z at
> org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> 2020-12-19T22:56:49.8175782Z at
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> 2020-12-19T22:56:49.8176188Z at
> org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> 2020-12-19T22:56:49.8176576Z at
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> 2020-12-19T22:56:49.8176965Z at
> org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> 2020-12-19T22:56:49.8177326Z at
> org.junit.runners.Suite.runChild(Suite.java:128)
> 2020-12-19T22:56:49.8177653Z at
> org.junit.runners.Suite.runChild(Suite.java:27)
> 2020-12-19T22:56:49.8178104Z at
> org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> 2020-12-19T22:56:49.8178706Z at
> org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> 2020-12-19T22:56:49.8179223Z at
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> 2020-12-19T22:56:49.8179781Z at
> org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> 2020-12-19T22:56:49.8180169Z at
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> 2020-12-19T22:56:49.8180565Z at
> org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> 2020-12-19T22:56:49.8180963Z at
> org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)
> 2020-12-19T22:56:49.8181435Z at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
> 2020-12-19T22:56:49.8181964Z at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:107)
> 2020-12-19T22:56:49.8182468Z at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:83)
> 2020-12-19T22:56:49.8182951Z at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75)
> 2020-12-19T22:56:49.8183446Z at
> org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:158)
> 2020-12-19T22:56:49.8183972Z at
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
> 2020-12-19T22:56:49.8184666Z at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
> 2020-12-19T22:56:49.8185157Z at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
> 2020-12-19T22:56:49.8185604Z at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
