tillrohrmann commented on a change in pull request #14431:
URL: https://github.com/apache/flink/pull/14431#discussion_r546659018
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterSchedulerTest.java
##########
@@ -72,16 +70,13 @@ public void
testIfStartSchedulingFailsJobMasterFailsFatally() throws Exception {
System.setSecurityManager(trackingSecurityManager);
final SchedulerNGFactory schedulerFactory = new
FailingSchedulerFactory();
- final JobMaster jobMaster = new JobMasterBuilder(new
JobGraph(), TESTING_RPC_SERVICE_RESOURCE
- .getTestingRpcService())
+ final JobMaster jobMaster = new JobMasterBuilder(new
JobGraph(), TESTING_RPC_SERVICE_RESOURCE.getTestingRpcService())
.withSchedulerFactory(schedulerFactory)
.createJobMaster();
- final CompletableFuture<Acknowledge> startFuture =
jobMaster.start(JobMasterId.generate());
+ jobMaster.start();
try {
- startFuture.join();
-
assertThat(trackingSecurityManager.getSystemExitFuture().join(),
is(FatalExitExceptionHandler.EXIT_CODE));
Review comment:
The signal is now sent via the `OnCompletionActions` and no longer via
the `SecurityManager`. I will update this test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
