wangxlong commented on a change in pull request #14387:
URL: https://github.com/apache/flink/pull/14387#discussion_r547069026
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/JdbcBatchingOutputFormat.java
##########
@@ -179,11 +178,9 @@ public synchronized void flush() throws IOException {
throw new IOException(e);
}
try {
- if
(!connection.isValid(CONNECTION_CHECK_TIMEOUT_SECONDS)) {
Review comment:
+1 to unify the scope and put it to `JdbcConnectionOptions `.
1. As it belongs to connection scope, so I think maybe we should add a
method `isConnectionValid` to `JdbcConnectionProvider` interface, and for this
, `JdbcBatchingOutputFormat` will properly use this without adding this config
to `executionOptions`.
2. For the lookupFunction and reader, we can get it directly from
`JdbcConnectionOptions `.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
