xiaoHoly commented on a change in pull request #14387:
URL: https://github.com/apache/flink/pull/14387#discussion_r548366071
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcConnectionOptions.java
##########
@@ -35,16 +35,18 @@
protected final String url;
protected final String driverName;
+ protected final int connectionCheckTimeoutSeconds;
@Nullable
protected final String username;
@Nullable
protected final String password;
- protected JdbcConnectionOptions(String url, String driverName, String
username, String password) {
+ protected JdbcConnectionOptions(String url, String driverName, String
username, String password, int connectionCheckTimeoutSeconds) {
this.url = Preconditions.checkNotNull(url, "jdbc url is empty");
this.driverName = Preconditions.checkNotNull(driverName,
"driver name is empty");
this.username = username;
this.password = password;
+ this.connectionCheckTimeoutSeconds =
connectionCheckTimeoutSeconds;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
