wangyang0918 commented on pull request #14281: URL: https://github.com/apache/flink/pull/14281#issuecomment-751613713
@blublinsky Thanks for your comments. First, I believe parsing the `KubernetesOwnerReference` is not the ability of `KubernetesJobManagerFactory`. Moving the parsing logics out could make it more testable and reusable[1]. Second, we already have the mechanism to parse the structured string to a map. It will help a lot to convert them to a `KubernetesOwnerReference`. Benefit from the map, we do not require the users to always set all the fields(e.g. `apiVersion`, `blockOwnerDeletion`, `controller`, `kind`, `name`, `uid`) in specific order. It will be easier to use. Last, I do not think it will introduce two much codes except for the tests. [1]. https://flink.apache.org/contributing/code-style-and-quality-common.html#design-for-testability ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
