blublinsky commented on a change in pull request #14512: URL: https://github.com/apache/flink/pull/14512#discussion_r549764142
########## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesOwnerReference.java ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.kubeclient.resources; + +import io.fabric8.kubernetes.api.model.OwnerReference; +import io.fabric8.kubernetes.api.model.OwnerReferenceBuilder; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Map; + +/** + * Represent Toleration resource in kubernetes. + */ +public class KubernetesOwnerReference extends KubernetesResource<OwnerReference> { + + static final String API_VERSION = "apiversion"; + static final String DELETION = "blockownerdeletion"; + static final String CONTROLLER = "controller"; + static final String KIND = "kind"; + static final String NAME = "name"; + static final String UUID = "uid"; + + private static final Logger LOG = LoggerFactory.getLogger(KubernetesOwnerReference.class); + + private KubernetesOwnerReference(OwnerReference ownerReference) { + super(ownerReference); + } + + public static KubernetesOwnerReference fromMap(Map<String, String> stringMap) { + final OwnerReferenceBuilder ownerReferenceBuilder = new OwnerReferenceBuilder(); + stringMap.forEach((k, v) -> { + switch (k.toLowerCase()) { Review comment: Here is the formal definition https://github.com/kubernetes/apimachinery/blob/21de1bffe600f61f4873ae774a60f7a7d37ac9bf/pkg/apis/meta/v1/types.go#L273-L275. According to it controller and BlockOwnerDeletion are optional. But for practical use, it is my understanding, that everything is required ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
