xintongsong commented on pull request #8952: URL: https://github.com/apache/flink/pull/8952#issuecomment-752320177
@HuangZhenQiu, Sorry for the late response. I don't think need to split the 100 LoC into `ThresholdMeter`, `TimestampBasedThresholdMeter`, and `FailureRater`. On the contrary, I think we should not have the concepts `FailureRater` and `TimestampBasedThresholdMeter` at all. Please see my other comment [here](https://github.com/apache/flink/pull/8952#discussion_r549927391). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
