[GitHub] [flink] rmetzger commented on a change in pull request #14499: [FLINK-15156] Warn user if System.exit() is called in user code

[GitBox]

rmetzger commented on a change in pull request #14499:
URL: https://github.com/apache/flink/pull/14499#discussion_r551774866



##########
File path: 
flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java
##########
@@ -490,4 +490,25 @@
                                     + "channel. If the `close_notify` was not 
flushed in the given timeout the channel will be closed "
                                     + "forcibly. (-1 = use system default)")
                     
.withDeprecatedKeys("security.ssl.close-notify-flush-timeout");
+
+    // ------------------------ security manager 
--------------------------------
+
+    /** Flag to check the attempt of main or user-defined function to 
terminate JVM. */
+    @Documentation.Section(Documentation.Sections.EXPERT_DEBUGGING_AND_TUNING)
+    public static final ConfigOption<String> CHECK_SYSTEM_EXIT =
+            key("security.check-system-exit")

Review comment:
       As commented already, I suggest to move this to the `cluster.` config 
namespace. I don't see this as a security setting, rather controlling the 
behavior of the process.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org