[GitHub] [flink] fsk119 commented on a change in pull request #14508: [FLINK-20773][format] Support allow-unescaped-control-chars option for JSON format.

[GitBox]

fsk119 commented on a change in pull request #14508:
URL: https://github.com/apache/flink/pull/14508#discussion_r551885965



##########
File path: 
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDataDeserializationSchema.java
##########
@@ -85,11 +90,15 @@ public JsonRowDataDeserializationSchema(
                 new JsonToRowDataConverters(failOnMissingField, 
ignoreParseErrors, timestampFormat)
                         .createConverter(checkNotNull(rowType));
         this.timestampFormat = timestampFormat;
+        this.allowUnescapedControlChars = allowUnescapedControlChars;
         boolean hasDecimalType =
                 LogicalTypeChecks.hasNested(rowType, t -> t instanceof 
DecimalType);
         if (hasDecimalType) {
             
objectMapper.enable(DeserializationFeature.USE_BIG_DECIMAL_FOR_FLOATS);
         }
+        objectMapper.configure(
+                JsonReadFeature.ALLOW_UNESCAPED_CONTROL_CHARS.mappedFeature(),
+                allowUnescapedControlChars);
     }
 
     @Override

Review comment:
       Please add comments to explain when  `ignore-parse-error` will fail.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org