Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1818#discussion_r56803957
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -109,22 +113,22 @@
private RestartStrategies.RestartStrategyConfiguration
restartStrategyConfiguration;
- private long taskCancellationIntervalMillis =
ConfigConstants.DEFAULT_TASK_CANCELLATION_INTERVAL_MILLIS;
+ private long taskCancellationIntervalMillis = -1;
// Serializers and types registered with Kryo and the PojoSerializer
// we store them in linked maps/sets to ensure they are registered in
order in all kryo instances.
- private final LinkedHashMap<Class<?>, SerializableSerializer<?>>
registeredTypesWithKryoSerializers = new LinkedHashMap<>();
+ private final UserCodeValue<LinkedHashMap<Class<?>,
SerializableSerializer<?>>> registeredTypesWithKryoSerializers = new
UserCodeValue<>(new LinkedHashMap<Class<?>, SerializableSerializer<?>>());
- private final LinkedHashMap<Class<?>, Class<? extends Serializer<?>>>
registeredTypesWithKryoSerializerClasses = new LinkedHashMap<>();
+ private final UserCodeValue<LinkedHashMap<Class<?>, Class<? extends
Serializer<?>>>> registeredTypesWithKryoSerializerClasses = new
UserCodeValue<>(new LinkedHashMap<Class<?>, Class<? extends Serializer<?>>>());
- private final LinkedHashMap<Class<?>, SerializableSerializer<?>>
defaultKryoSerializers = new LinkedHashMap<>();
+ private final UserCodeValue<LinkedHashMap<Class<?>,
SerializableSerializer<?>>> defaultKryoSerializers = new UserCodeValue<>(new
LinkedHashMap<Class<?>, SerializableSerializer<?>>());
- private final LinkedHashMap<Class<?>, Class<? extends Serializer<?>>>
defaultKryoSerializerClasses = new LinkedHashMap<>();
+ private final UserCodeValue<LinkedHashMap<Class<?>, Class<? extends
Serializer<?>>>> defaultKryoSerializerClasses = new UserCodeValue<>(new
LinkedHashMap<Class<?>, Class<? extends Serializer<?>>>());
- private final LinkedHashSet<Class<?>> registeredKryoTypes = new
LinkedHashSet<>();
+ private final UserCodeValue<LinkedHashSet<Class<?>>>
registeredKryoTypes = new UserCodeValue<>(new LinkedHashSet<Class<?>>());
- private final LinkedHashSet<Class<?>> registeredPojoTypes = new
LinkedHashSet<>();
+ private final UserCodeValue<LinkedHashSet<Class<?>>>
registeredPojoTypes = new UserCodeValue<>(new LinkedHashSet<Class<?>>());
--- End diff --
That is true, I will fix it. Personally, I think this `GlobalJobParameters`
is a huge crime. It basically allows you to store anything in the
`ExecutionConfig`. Sometimes I'm overcome with the feeling that this
`ExecutionConfig` is simply a dumping ground for all kinds of parameters which
are somehow needed somewhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
