KarmaGYZ commented on a change in pull request #14612: URL: https://github.com/apache/flink/pull/14612#discussion_r556287199
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTableImpl.java ########## @@ -319,7 +321,7 @@ public boolean allocateSlot( taskSlot = new TaskSlot<>( index, - resourceProfile, + effectiveResourceProfile, Review comment: Yes, it should actually be a hotfix for FLINK-20837. We treat the matching of resource profile as one of the conditions to judge the duplicate slot. So we need to move this transition forward. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org