wuchong commented on a change in pull request #14536: URL: https://github.com/apache/flink/pull/14536#discussion_r556316339
########## File path: flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/source/AbstractHBaseDynamicTableSource.java ########## @@ -114,4 +117,28 @@ public String asSummaryString() { public HBaseTableSchema getHBaseTableSchema() { return this.hbaseSchema; } + + // get HBase table properties which start with prefix + public static Properties getHBaseClientProperties( + Map<String, String> tableOptions, String prefix) { Review comment: I think we don't need the `prefix` parameter, the prefix should always be `properties.`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org