wenlong88 commented on a change in pull request #14606:
URL: https://github.com/apache/flink/pull/14606#discussion_r556453838
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecHashJoin.java
##########
@@ -84,14 +70,7 @@ public BatchExecHashJoin(
RowType outputType,
String description) {
super(inputEdges, outputType, description);
- this.joinType = checkNotNull(joinType);
- this.leftKeys = checkNotNull(leftKeys);
- this.rightKeys = checkNotNull(rightKeys);
- this.filterNulls = checkNotNull(filterNulls);
- checkArgument(leftKeys.length > 0 && leftKeys.length ==
rightKeys.length);
Review comment:
I would add the validation in translatedToPlanInternal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
