[GitHub] [flink] chaozwn commented on a change in pull request #14536: [FLINK-20812][Connector][Hbase] hbase in sql mode,can use 'properties.*' add Configuration parameter.

[GitBox]

chaozwn commented on a change in pull request #14536:
URL: https://github.com/apache/flink/pull/14536#discussion_r557100620



##########
File path: 
flink-connectors/flink-connector-hbase-1.4/src/main/java/org/apache/flink/connector/hbase1/HBase1DynamicTableFactory.java
##########
@@ -74,13 +72,13 @@ public DynamicTableSource createDynamicTableSource(Context 
context) {
         validatePrimaryKey(tableSchema);
         validateTableSourceOptions(tableOptions);

Review comment:
       validatePrimaryKey is necessary，The other can be removed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org